Fix IDE formatting of correctly formatted files with trailing newlines#9683
Closed
mszabo-wikia wants to merge 1 commit intofacebook:masterfrom
Closed
Fix IDE formatting of correctly formatted files with trailing newlines#9683mszabo-wikia wants to merge 1 commit intofacebook:masterfrom
mszabo-wikia wants to merge 1 commit intofacebook:masterfrom
Conversation
|
@facebook-github-bot has imported this pull request. If you are a Meta employee, you can view this in D88329959. (Because this pull request was imported automatically, there will not be any future comments.) |
mszabo-wikia
force-pushed
the
fix-formatting-of-trailing-newlines
branch
from
0f26849 to
419cd56
Compare
Contributor
|
@mszabo-wikia has updated the pull request. You must reimport the pull request before landing. |
mszabo-wikia
force-pushed
the
fix-formatting-of-trailing-newlines
branch
from
419cd56 to
f338f52
Compare
Contributor
|
@mszabo-wikia has updated the pull request. You must reimport the pull request before landing. |
Since D60978552, we special-case removing a range of lines during IDE formatting so that T188437747 does not rear its ugly head. However, when document-formatting a file that is already correctly formatted save for some spurious trailing newlines, this logic ends up consuming the last non-newline line. So, only shift the start offset if the last changed line wasn't a trailing line that got removed. Add a test and wire up `hh_single_ide_format` with the OSS dune build so that IDE format tests can be run.
mszabo-wikia
force-pushed
the
fix-formatting-of-trailing-newlines
branch
from
f338f52 to
bc21be9
Compare
Contributor
|
@mszabo-wikia has updated the pull request. You must reimport the pull request before landing. |
|
This pull request has been merged in 21784c0. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since D60978552, we special-case removing a range of lines during IDE formatting so that T188437747 does not rear its ugly head. However, when document-formatting a file that is already correctly formatted save for some spurious trailing newlines, this logic ends up consuming the last non-newline line. So, only shift the start offset if the last changed line wasn't a trailing line that got removed.
Add a test and wire up
hh_single_ide_formatwith the OSS dune build so that IDE format tests can be run.