Support load("uv.lock?as=toml", "value") syntax#1287
Open
cormacrelf wants to merge 1 commit intofacebook:mainfrom
Open
Support load("uv.lock?as=toml", "value") syntax#1287cormacrelf wants to merge 1 commit intofacebook:mainfrom
load("uv.lock?as=toml", "value") syntax#1287cormacrelf wants to merge 1 commit intofacebook:mainfrom
Conversation
Because the only other way to import these files is to symlink them with a name ending with .toml. And that doesn't work as BUCK does not propagate file invalidation to symlinks to changed files.
Contributor
|
@facebook-github-bot has imported this pull request. If you are a Meta employee, you can view this in D100180404. (Because this pull request was imported automatically, there will not be any future comments.) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Alternative to #1286.
Here's that alternative. The example becomes
and basically this works. This code I do understand quite well, and it's simple and there are no X factors as to how to get it to work.