Skip to content

Conversation

@MatkoKardum
Copy link

Describe your changes

Issue ticket number and link if any Closes #2803 #2803

Checklist for finalizing the PR

  • [ T] I have performed a self-review of my code
  • [ F] I have added tests for new features and bugfixes
  • [ F] I have added documentation for new features
  • [ F] If it is a modifying the libf3d API, I have updated bindings
  • [ F] If it is a modifying the .github/workflows/versions.json, I have updated docker_timestamp

Continuous integration

Please write a comment to run CI, eg: \ci fast.
See here for more info.

@MatkoKardum
Copy link
Author

\ci fast

Copy link
Author

@MatkoKardum MatkoKardum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed the syntax that got auto formatted by my IDE

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what is this file ?


ImVec2 position(
viewport->WorkSize.x - winSize.x - margin, viewport->WorkSize.y - winSize.y - margin);
ImVec2 position(viewport->WorkSize.x - winSize.x - margin, margin);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

are you sure that works as intended ? I would expect test baselines to be impacted.

Copy link
Member

@mwestphal mwestphal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

some questions

@mwestphal
Copy link
Member

(Please ask for review once you have adressed/answered the questions)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Move FPS timer next to the console badge instead of below the axis widget

2 participants