-
-
Notifications
You must be signed in to change notification settings - Fork 373
Move FPS timer next to console badge as requested in #2803 #2821
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
\ci fast |
Fix loop syntax for iterating over FolderWatchIds.
Fix loop condition in folder unwatching logic.
MatkoKardum
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed the syntax that got auto formatted by my IDE
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what is this file ?
|
|
||
| ImVec2 position( | ||
| viewport->WorkSize.x - winSize.x - margin, viewport->WorkSize.y - winSize.y - margin); | ||
| ImVec2 position(viewport->WorkSize.x - winSize.x - margin, margin); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
are you sure that works as intended ? I would expect test baselines to be impacted.
mwestphal
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
some questions
|
(Please ask for review once you have adressed/answered the questions) |
Describe your changes
Issue ticket number and link if any Closes #2803 #2803
Checklist for finalizing the PR
.github/workflows/versions.json, I have updateddocker_timestampContinuous integration
Please write a comment to run CI, eg:
\ci fast.See here for more info.