DRAFT: Add TIME_STEPS to RequestInformation to AlembicReader #2791
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mwestphal
reviewed
Jan 7, 2026
| Alembic::Abc::IObject top = this->Archive.getTop(); | ||
|
|
||
| std::set<double> timeStepSet; | ||
| std::stack<std::pair<const Alembic::Abc::IObject, const Alembic::Abc::ObjectHeader>> objects; |
Member
There was a problem hiding this comment.
why is ths std::stack needed ?
Contributor
There was a problem hiding this comment.
to navigate through Archive without doing recursive call
Ni-g-3l
reviewed
Jan 7, 2026
| Alembic::Abc::IObject top = this->Archive.getTop(); | ||
|
|
||
| std::set<double> timeStepSet; | ||
| std::stack<std::pair<const Alembic::Abc::IObject, const Alembic::Abc::ObjectHeader>> objects; |
Contributor
There was a problem hiding this comment.
to navigate through Archive without doing recursive call
mwestphal
reviewed
Jan 7, 2026
Member
mwestphal
left a comment
mwestphal
left a comment
There was a problem hiding this comment.
alright, that looks good, lets add a test then :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
Issue ticket number and link if any
Checklist for finalizing the PR
.github/workflows/versions.json, I have updateddocker_timestampContinuous integration
Please write a comment to run CI, eg:
\ci fast.See here for more info.