fix(release): resume tagged publish runs#88
Closed
f0rr0 wants to merge 3 commits into
Closed
Conversation
* chore(release): prepare main releases * chore(release): prepare main releases * chore(release): sync derived release files --------- Co-authored-by: oliphaunt-release-bot <oliphaunt-release-bot@users.noreply.github.com>
Owner
Author
|
Superseded after resetting main for a clean release path. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
publishplanning include current-version product tags so a run can resume after release-please created GitHub releases/tags but a later step failed0.1.0fail before release-please creates more side effectsValidation
tools/dev/bun.sh tools/release/release_plan.mjs --from-product-tags --include-current-tags --include-current-version-tags --head-ref origin/main --format github-outputtools/dev/bun.sh tools/release/verify_product_tags.mjs --products-json '["liboliphaunt-native","oliphaunt-swift","oliphaunt-js"]' --target origin/mainbash -n .github/scripts/resolve-release-head.shtools/dev/bun.sh tools/release/release-check.mjsgit diff --checkRelease note
The currently failed publish run already created
*-v0.1.0product releases/tags. With this fix merged, a publish rerun will continue selecting those products instead of reporting no release changes.One external cleanup remains before the Swift publish step can succeed: the repository still has legacy plain semver tags/releases such as
0.1.0.oliphaunt-swiftpublishes a SwiftPM semver tag for its package version, so0.1.0must either be removed from the old pglite release history or the Swift product must be released at a non-conflicting version.