fix(release): verify release-please product tags#83
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
originbefore verification so tags created by release-please after checkout are visible to later publish stepsRoot Cause
The grouped release PR title
chore(release): prepare product releaseshad no release-please parser placeholders. On publish, release-please found PR #80 but could not parse its title, so it created no product tags/releases and exited successfully. The first asset publish then failed on the missingliboliphaunt-native-v0.1.0tag.This keeps PR #80 recoverable because the new grouped pattern parses both the old title (
product) and future generated titles (main).After Merge
Run the Release workflow from
mainwith:operation:publishrelease_commit: leave empty unless you intentionally want to publish a specific full commit SHAExpected behavior after this fix: release-please creates the product tags/releases first,
Verify release-please product tagsfetches and verifies all selected<product>-v<version>tags at the release commit, then publishing begins. If release-please ever creates no tags again, the workflow fails before any publish step runs.Validation
tools/dev/bun.sh tools/release/release-check.mjstools/dev/bun.sh tools/release/check_release_please_config.mjs && tools/dev/bun.sh tools/policy/check-release-policy.mjstools/dev/bun.sh tools/release/verify_product_tags.mjs --products-json '["liboliphaunt-native"]' --target origin/main