Add PR number to commit messages during land #314
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR modifies
ghstack landto append the PR number to commit messages, matching GitHub's native merge behavior.Changes
land.py:(#<PR_NUMBER>)to the subject linesubmit.py:check_invariantsvalidationExample
Before:
After landing PR #456:
Testing
All 10 existing land tests pass. Tests were updated to expect PR numbers in commit messages using
EXPECTTEST_ACCEPT=1.Closes #313