fix: refresh cookie options for rolling sessions#1120
Open
raashish1601 wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Refresh cookie options from the current middleware configuration when an existing session is loaded with
rolling: true.This keeps rolled
Set-Cookieheaders in sync after deployments that change cookie settings such assameSiteormaxAge, while preserving the existing session id and store entry.Fixes #1077.
Validation
npx mocha --require test/support/env --check-leaks --no-exit --reporter spec --grep "rolling option" test/session.jsnpx eslint index.js test/session.jsbash -lc "tr -d '\r' < test/support/gencert.sh | bash"npx mocha --require test/support/env --check-leaks --no-exit --reporter spec test/npm run lintgit diff --checknpm testitself cannot be launched from this Windows shell because the npm script starts with./test/support/gencert.sh, whichcmdrejects as'.' is not recognized. I ran the certificate script through bash after stripping checkout CRLFs, then ran the full mocha suite directly.