Skip to content

fix(snackager): check HTTP status and handle stream errors when fetching tarballs #673

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ide wants to merge 2 commits into
base: main
Choose a base branch
from
Open

fix(snackager): check HTTP status and handle stream errors when fetching tarballs #673

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2e825ad
fix(snackager): check HTTP status and handle stream errors when fetch…
ide Feb 24, 2026
3de5f0f
Fix lint
ide Feb 24, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 9 additions & 3 deletions snackager/src/utils/fetchAndExtract.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,16 +18,22 @@ export default async function fetchAndExtract(

logger.info({ pkg, url }, `fetching tarball`);

const request = await fetch(url, {
const response = await fetch(url, {
timeout: 10000,
});

const write = createWriteStream(path.join(dir, 'package.tgz'));
if (!response.ok) {
throw new Error(
`Failed to fetch tarball from ${url}: ${response.status} ${response.statusText}`,
);
}

request.body.pipe(write);
const write = createWriteStream(path.join(dir, 'package.tgz'));

return new Promise((resolve, reject) => {
response.body.on('error', reject);
write.on('error', reject);
response.body.pipe(write);
write.on('finish', async () => {
logger.info({ pkg, dir }, `extracting`);
targz.decompress(
Expand Down