chore: remove unnecessary ViewerScopedEntityMutatorFactory#599
Open
wschurman wants to merge 1 commit into
Open
Conversation
Member
Author
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #599 +/- ##
==========================================
Coverage 100.00% 100.00%
==========================================
Files 110 109 -1
Lines 17694 17607 -87
Branches 911 1514 +603
==========================================
- Hits 17694 17607 -87
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
wschurman
force-pushed
the
05-13-chore_make_viewercontext_specification_explicit_for_viewerscopedentitymutatorfactory
branch
from
181256e to
aab4b91
Compare
wschurman
changed the title
wschurman
force-pushed
the
05-13-chore_make_viewercontext_specification_explicit_for_viewerscopedentitymutatorfactory
branch
from
aab4b91 to
0d2eade
Compare
This was referenced May 13, 2026
This was referenced May 14, 2026
ide
approved these changes
May 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
ViewerScopedEntityMutatorFactory existed to make both the loader and mutator patterns more aligned. But it doesn't make as much sense for mutators since for update and delete, the viewerContext used is the one from the entity being updated/deleted instead of the one for the viewer scoped factory. So, in practice the one from the factory was only being used for create mutations.
The simplest change is to just remove the ViewerScopedEntityMutatorFactory to reduce confusion.
How
Remove class.
Test Plan
CI