Skip to content

Fix ipool id annotation when using sks nodepool & cluster name #136

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kobajagi merged 3 commits into from
Mar 25, 2026
Merged

Fix ipool id annotation when using sks nodepool & cluster name #136

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
06147ec
Fix ipool id annotation when using sks nodepool & cluster name annota…
kobajagi Mar 25, 2026
e8c9214
Update CHANGELOG.md
kobajagi Mar 25, 2026
19ba7d3
Add nil-pointer guard
kobajagi Mar 25, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@
## Unreleased

* chore(golang): bump golang to 1.26.x
* fix: set correct ipool id in annotation when using sks nodepool & cluster name #136

## 0.34.0

Expand Down
4 changes: 2 additions & 2 deletions exoscale/loadbalancer.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -152,8 +152,8 @@ func (l *loadBalancer) EnsureLoadBalancer(
// Find the SKS node pool ID by name
var instancePoolID v3.UUID
for _, pool := range sksCluster.Nodepools {
if strings.EqualFold(pool.Name, sksNodePoolName) {
instancePoolID = pool.ID
if strings.EqualFold(pool.Name, sksNodePoolName) && pool.InstancePool != nil {
instancePoolID = pool.InstancePool.ID
break
}
}
Expand Down
Loading