Open
Conversation
M5 gen uses lowercase fan mode key (F%dmd) instead of F%dMd, and lacks the Ftst key used for fan unlock on M1-M4. Runtime-detect the correct key name via SMC probe, and restructure unlockFanControl/resetFanControl to work without Ftst in the case of M5 gen.
Owner
|
can confirm that it works fine for m1 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fan control is broken on M5 gen. Setting mode or speed through the UI or smc CLI does nothing, even though RPM reads work fine.
Two issues: M5 uses F%dmd (lowercase) for the fan mode key instead of F%dMd, and the uppercase key doesn't exist so writes are silently ignored. Second, Ftst doesn't exist on M5, but unlockFanControl bails out immediately if it can't read Ftst.
Changes:
Tested on MacBook Pro 14" M5 Pro (15-core CPU): manual mode, speed control, and reset all work correctly through both the CLI and the Stats UI. Would appreciate confirmation on base M5, M5 Max, and M1-M4 to make sure nothing regressed.