feat: implmeent concurrent download support with context handling - #21
Merged
Conversation
- Add context.Context to downloadImage() - Configurable thread count for concurrent download via SetThreads() - Add DownloadIllustIter() and DownloadIllustAsync() for streaming downloads - Extract getting urls from illust logic into illustGetUrls() helper func - Refactor downloadBytes() to downloadImage() returning structured Image type contains img data, page num and image format - Maintain backward compatibility with existing Download() and DownloadBytes() methods
Miuzarte
marked this pull request as ready for review
November 22, 2025 18:32
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
实现了隐式多线程下载，DownloadIllustIter() 取得的数据仍是按顺序的
@everpcpc 先review？哪里有问题我后面再改改，有点breaking