Conversation
Bumps [locutus](https://github.com/locutusjs/locutus) from 2.0.38 to 2.0.39. - [Release notes](https://github.com/locutusjs/locutus/releases) - [Changelog](https://github.com/locutusjs/locutus/blob/main/CHANGELOG.md) - [Commits](locutusjs/locutus@v2.0.38...v2.0.39) --- updated-dependencies: - dependency-name: locutus dependency-version: 2.0.39 dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com>
…-2.0.39 chore(deps): bump locutus from 2.0.38 to 2.0.39
…tionality-lo [Feat] Implement load more functionality
* fix(settings): revert add plugin component UI Revert the add plugin component with a grid-based layout for installation options. Enhance accessibility by adding ARIA attributes and keyboard event handlers. Update the template to utilize Angular Signals and improve the overall form structure and error reporting. * fix(plugin): update auth token handling method and adjust imports * feat(ui): add visible label for cdn url input Add a visible label element linked to the CDN URL input field and remove the redundant aria-label attribute. This improves accessibility and ensures the input is properly identified by screen readers. * fix(add-plugin): prevent default space key behavior and add aria-disabled attribute during installation * fix(add-plugin): improve error handling display and add comments for clarity
* fix: desktop timer serve mode * fix: desktop timer ui * fix: desktop timer ui * fix: desktop timer ui * fix: desktop timer style not loaded * fix: task component path
fix: desktop translate not loaded
[Fix] Upgrade Swiper Support
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the
✨ Finishing touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
|
|
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
There was a problem hiding this comment.
3 issues found across 63 files
Prompt for AI agents (all issues)
Check if these issues are valid — if so, understand the root cause of each and fix them.
<file name="packages/desktop-ui-lib/src/lib/time-tracker/task-table/table/task-table.component.ts">
<violation number="1" location="packages/desktop-ui-lib/src/lib/time-tracker/task-table/table/task-table.component.ts:30">
P2: OnPush is enabled, but async updates to `smartTableSettings`/`smartTableSource` happen in subscriptions/callbacks without `markForCheck()`. With OnPush, the view may not refresh on language changes or selector updates. Add `ChangeDetectorRef.markForCheck()` after these updates or wire them through async bindings.</violation>
</file>
<file name="apps/desktop-timer/src/app/app-routing.module.ts">
<violation number="1" location="apps/desktop-timer/src/app/app-routing.module.ts:28">
P2: AuthModule is already eagerly imported in AppModule, so lazy-loading it here will create duplicate module instances and router config. Prefer using the route array (authRoutes) or remove AuthModule from AppModule to keep a single load path.</violation>
<violation number="2" location="apps/desktop-timer/src/app/app-routing.module.ts:35">
P2: RecapModule is already imported in AppModule, so lazy-loading it here duplicates module instances and routes. Use the route array (recapRoutes) or remove RecapModule from AppModule to keep a single loading strategy.</violation>
</file>
Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.
| selector: 'ngx-task-table', | ||
| templateUrl: './task-table.component.html', | ||
| styleUrls: ['./task-table.component.scss'], | ||
| changeDetection: ChangeDetectionStrategy.OnPush, |
There was a problem hiding this comment.
P2: OnPush is enabled, but async updates to smartTableSettings/smartTableSource happen in subscriptions/callbacks without markForCheck(). With OnPush, the view may not refresh on language changes or selector updates. Add ChangeDetectorRef.markForCheck() after these updates or wire them through async bindings.
Prompt for AI agents
Check if this issue is valid — if so, understand the root cause and fix it. At packages/desktop-ui-lib/src/lib/time-tracker/task-table/table/task-table.component.ts, line 30:
<comment>OnPush is enabled, but async updates to `smartTableSettings`/`smartTableSource` happen in subscriptions/callbacks without `markForCheck()`. With OnPush, the view may not refresh on language changes or selector updates. Add `ChangeDetectorRef.markForCheck()` after these updates or wire them through async bindings.</comment>
<file context>
@@ -27,6 +27,7 @@ import { SearchTermStore } from '../search/+state/search-term.store';
selector: 'ngx-task-table',
templateUrl: './task-table.component.html',
styleUrls: ['./task-table.component.scss'],
+ changeDetection: ChangeDetectionStrategy.OnPush,
standalone: false
})
</file context>
| component: TimeTrackerComponent, | ||
| canActivate: [AppModuleGuard, AuthGuard, AuthConnectionGuard], | ||
| loadChildren: () => import('@gauzy/desktop-ui-lib').then((m) => m.recapRoutes) | ||
| loadChildren: () => import('@gauzy/desktop-ui-lib').then((m) => m.RecapModule) |
There was a problem hiding this comment.
P2: RecapModule is already imported in AppModule, so lazy-loading it here duplicates module instances and routes. Use the route array (recapRoutes) or remove RecapModule from AppModule to keep a single loading strategy.
Prompt for AI agents
Check if this issue is valid — if so, understand the root cause and fix it. At apps/desktop-timer/src/app/app-routing.module.ts, line 35:
<comment>RecapModule is already imported in AppModule, so lazy-loading it here duplicates module instances and routes. Use the route array (recapRoutes) or remove RecapModule from AppModule to keep a single loading strategy.</comment>
<file context>
@@ -25,14 +25,14 @@ const routes: Routes = [
component: TimeTrackerComponent,
canActivate: [AppModuleGuard, AuthGuard, AuthConnectionGuard],
- loadChildren: () => import('@gauzy/desktop-ui-lib').then((m) => m.recapRoutes)
+ loadChildren: () => import('@gauzy/desktop-ui-lib').then((m) => m.RecapModule)
},
{
</file context>
| { | ||
| path: 'auth', | ||
| loadChildren: () => import('@gauzy/desktop-ui-lib').then((m) => m.authRoutes), | ||
| loadChildren: () => import('@gauzy/desktop-ui-lib').then((m) => m.AuthModule), |
There was a problem hiding this comment.
P2: AuthModule is already eagerly imported in AppModule, so lazy-loading it here will create duplicate module instances and router config. Prefer using the route array (authRoutes) or remove AuthModule from AppModule to keep a single load path.
Prompt for AI agents
Check if this issue is valid — if so, understand the root cause and fix it. At apps/desktop-timer/src/app/app-routing.module.ts, line 28:
<comment>AuthModule is already eagerly imported in AppModule, so lazy-loading it here will create duplicate module instances and router config. Prefer using the route array (authRoutes) or remove AuthModule from AppModule to keep a single load path.</comment>
<file context>
@@ -25,14 +25,14 @@ const routes: Routes = [
{
path: 'auth',
- loadChildren: () => import('@gauzy/desktop-ui-lib').then((m) => m.authRoutes),
+ loadChildren: () => import('@gauzy/desktop-ui-lib').then((m) => m.AuthModule),
canActivate: [AppModuleGuard, AuthConnectionGuard]
},
</file context>
|
View your CI Pipeline Execution ↗ for commit 4d72505
☁️ Nx Cloud last updated this comment at |
4 participants
PR
Please note: we will close your PR without comment if you do not check the boxes above and provide ALL requested information.
Summary by cubic
Fixes macOS signing/notarization and stabilizes desktop builds, while modernizing UI components. Adds pagination with “Load more” for pending plugin installations.
New Features
Bug Fixes
Written for commit 4d72505. Summary will update on new commits.