Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the
✨ Finishing touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Greptile OverviewGreptile SummaryThis PR fixes desktop application build issues by addressing Python dependency installation failures and TypeScript compilation errors. Key Changes
PR Template ComplianceThe PR description checkboxes are not checked, which violates the contributing guidelines (custom rule 90653f25-bd57-4517-ae57-772fe2013d9c). Confidence Score: 4/5
Important Files Changed
Sequence DiagramsequenceDiagram
participant GHA as GitHub Actions Workflow
participant Python as Python Package Manager
participant Yarn as Yarn Build Process
participant TS as TypeScript Compiler
participant Packages as Package Build System
Note over GHA,Python: Workflow Initialization
GHA->>Python: pip install --break-system-packages packaging setuptools
alt Installation succeeds
Python-->>GHA: Success
else Installation fails (flag not supported)
Python-->>GHA: Error
GHA->>Python: pip install packaging setuptools (fallback)
Python-->>GHA: Success
end
Note over Yarn,Packages: Desktop App Build Process
Yarn->>Packages: build:package:all:prod (NEW)
Packages->>TS: Build all packages with production config
Note over Packages: Includes constants, contracts, common, utils,<br/>plugin packages, and desktop packages
TS-->>Packages: All packages built
Packages-->>Yarn: Build complete
Yarn->>TS: ng:prod build desktop
TS->>TS: Load tsconfig.app.json
Note over TS: types: ["google.maps"] now included
TS-->>Yarn: Compilation successful
Note over GHA: Build artifacts ready for electron-builder
|
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
🤖 Augment PR SummarySummary: Improves CI robustness and build ordering for desktop/server desktop app builds. Changes:
🤖 Was this summary useful? React with 👍 or 👎 |
![augmentcode[bot]](https://avatars.githubusercontent.com/in/1027498?s=60&v=4){kind=small}
|
|
||
| - name: Fix node-gyp and Python | ||
| run: python3 -m pip install --break-system-packages packaging setuptools | ||
| run: python3 -m pip install --break-system-packages packaging setuptools || python3 -m pip install packaging setuptools |
There was a problem hiding this comment.
Using cmd1 || cmd2 will fall back to installing without --break-system-packages on any failure (not just “unknown option”), which can change behavior and obscure the real root cause. Consider narrowing the fallback to only the flag-not-supported scenario so genuine install failures aren’t retried with different semantics.
Other Locations
.github/workflows/agent-stage.yml:228.github/workflows/desktop-app-prod.yml:228.github/workflows/desktop-app-stage.yml:228.github/workflows/desktop-timer-app-prod.yml:228.github/workflows/desktop-timer-app-stage.yml:228.github/workflows/server-api-prod.yml:228.github/workflows/server-api-stage.yml:228.github/workflows/server-mcp-prod.yml:228.github/workflows/server-mcp-stage.yml:228.github/workflows/server-prod.yml:228.github/workflows/server-stage.yml:228
🤖 Was this useful? React with 👍 or 👎, or 🚀 if it prevented an incident/outage.
| @@ -1,3 +1,5 @@ | |||
| /// <reference types="google.maps" /> | |||
There was a problem hiding this comment.
Adding /// <reference types="google.maps" /> in @gauzy/ui-core makes @types/google.maps a transitive requirement for any consumer compiling against this package’s typings (outside this monorepo it could surface as a missing-types failure). If ui-core is published/consumed independently, consider ensuring that dependency is reflected in packages/ui-core/package.json (or otherwise scoped so only apps that need Maps types pull it in).
🤖 Was this useful? React with 👍 or 👎, or 🚀 if it prevented an incident/outage.
1 participant
PR
Please note: we will close your PR without comment if you do not check the boxes above and provide ALL requested information.
Summary by cubic
Stabilizes desktop builds in CI by adding a pip fallback, fixing missing Google Maps types, and building shared packages before Electron builds. Improves reliability for desktop, timer, agent, server, and MCP server builds across OSes.
Bug Fixes
New Features
Written for commit a373fc0. Summary will update on new commits.