ENG-3714: Form builder registry, SSE streaming, and useFormBuilder hook#8205
Draft
jpople wants to merge 1 commit into
Draft
Conversation
Contributor
|
The latest updates on your projects. Learn more about Vercel for GitHub.
1 Skipped Deployment
|
…ok with sanitizeSpec
jpople
force-pushed
the
jpople/eng-3714/form-builder-pc-rendering
branch
from
a1d4a57 to
f51cfc5
Compare
jpople
force-pushed
the
jpople/eng-3714/form-builder-registry-streaming
branch
from
a78c25c to
b29cd26
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
registry.tsx— json-render component bindings for all 9 field typesLocationField.tsxandPhoneField.tsxwith dynamic importsstreaming.ts— SSE parser andstreamChatTurnfetch wrapperuseFormBuilder.ts— state machine hook withsanitizeSpec()security hardeningjest.setup.tsfor nwsapi/jsdom compat with antd v6Security
sanitizeSpec()strips elements with unknown component types before rendering in preview, defending against malicious LLM responses.Test plan
npx jest --testPathPattern="(registry|streaming|useFormBuilder)"— all pass