ENG-3714: Privacy center field_order, visibility, and radio type#8204
Draft
jpople wants to merge 1 commit into
Draft
ENG-3714: Privacy center field_order, visibility, and radio type#8204jpople wants to merge 1 commit into
jpople wants to merge 1 commit into
Conversation
Contributor
|
The latest updates on your projects. Learn more about Vercel for GitHub. 2 Skipped Deployments
|
jpople
force-pushed
the
jpople/eng-3714/form-builder-base
branch
from
1012ecf to
516f883
Compare
jpople
force-pushed
the
jpople/eng-3714/form-builder-pc-rendering
branch
from
a1d4a57 to
f51cfc5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
buildOrderedFieldsto resolve field render order fromfield_order(fixes identity field reorder bug)visibility.tswithisFieldVisible()for conditional field renderingradiofield type toCustomFieldRendererplaceholderprop passthrough for all field typesPrivacyRequestFormfrom hardcoded identity-first toorderedFields.map(renderField)useCustomFieldsFormTest plan
npx jest --testPathPattern="buildOrderedFields"— 9 tests passfield_orderuse existing sequence