fix(cmd): resolve db command data-dir and verbosity from config#5516
Closed
gacevicljubisa wants to merge 1 commit into
Closed
fix(cmd): resolve db command data-dir and verbosity from config#5516gacevicljubisa wants to merge 1 commit into
gacevicljubisa wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
Description
bee db <cmd> --config=...failed withno data-dir providedbecause the db subcommands read flags directly and ignored the loaded config file.PreRunE(composing with the root's config load, likestart/initdo).data-dirandverbosityviac.config, so both follow the usual precedence: flag → env → config file.Result:
An explicit
--data-dir/--verbositystill wins; an emptydata-diris the only required-key check. Added tests for config fallback, flag-over-config precedence, and the required-key error.Open API Spec Version Changes (if applicable)
Motivation and Context (Optional)
The db maintenance commands should reuse the same config file as the node so operators don't have to re-pass
--data-dirthat already lives in their config.Related Issue (Optional)
Screenshots (if appropriate):
AI Disclosure