Fix test_measure_gas tests for Amsterdam#2618
Draft
kclowes wants to merge 1 commit intoethereum:eips/amsterdam/eip-8037from
Draft
Fix test_measure_gas tests for Amsterdam#2618kclowes wants to merge 1 commit intoethereum:eips/amsterdam/eip-8037from
kclowes wants to merge 1 commit intoethereum:eips/amsterdam/eip-8037from
Conversation
kclowes
commented
Apr 3, 2026
| Bytes("693c6139") + Hash(0x3B), | ||
| ] | ||
| tx_gas = [16777216] | ||
| tx_gas = [20000000] |
Contributor
Author
There was a problem hiding this comment.
After Amsterdam, tx.gas can exceed 16.7M, and the remainder will go in the reservoir to be used as state_gas.
kclowes
commented
Apr 3, 2026
| { | ||
| "indexes": {"data": [0], "gas": -1, "value": -1}, | ||
| "network": [">=Amsterdam"], | ||
| "result": {contract_12: Account(storage={0: 9089})}, |
Contributor
Author
There was a problem hiding this comment.
Amsterdam: REGULAR_GAS_CREATE = 9000 + 89 overhead (no state gas taken into account here)
Pre-Ams: REGULAR_GAS_CREATE = 32000 + 89 overhead
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## eips/amsterdam/eip-8037 #2618 +/- ##
==========================================================
Coverage ? 87.39%
==========================================================
Files ? 476
Lines ? 27899
Branches ? 2685
==========================================================
Hits ? 24383
Misses ? 3042
Partials ? 474
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🗒️ Description
Fix for stBadOpcode tests. Added a higher tx_gas value, and checks for gas values in Amsterdam and later.
🔗 Related Issues or PRs
#2601
✅ Checklist
just statictype(scope):.mkdocs servelocally and verified the auto-generated docs for new tests in the Test Case Reference are correctly formatted.@ported_frommarker.Cute Animal Picture