Skip to content

feat(test-benchmark): add missing target opcodes for SMOD, MOD and EXP#2613

Merged
LouisTsai-Csie merged 1 commit intoethereum:forks/amsterdamfrom
jsign:jsign-missing-target-opcode
Apr 2, 2026
Merged

feat(test-benchmark): add missing target opcodes for SMOD, MOD and EXP#2613
LouisTsai-Csie merged 1 commit intoethereum:forks/amsterdamfrom
jsign:jsign-missing-target-opcode

Conversation

@jsign
Copy link
Copy Markdown
Collaborator

@jsign jsign commented Apr 1, 2026

🗒️ Description

Add missing target_opcode proper setup for EXP, MOD and SMOD cases.

🔗 Related Issues or PRs

N/A.

✅ Checklist

  • All: Ran fast static checks to avoid unnecessary CI fails, see also Code Standards and Enabling Pre-commit Checks:
    just static
  • All: PR title adheres to the repo standard - it will be used as the squash commit message and should start type(scope):.
  • All: Considered updating the online docs in the ./docs/ directory.
  • All: Set appropriate labels for the changes (only maintainers can apply labels).
  • Tests: Ran mkdocs serve locally and verified the auto-generated docs for new tests in the Test Case Reference are correctly formatted.
  • Tests: For PRs implementing a missed test case, update the post-mortem document to add an entry the list.
  • Ported Tests: All converted JSON/YML tests from ethereum/tests or tests/static have been assigned @ported_from marker.

Cute Animal Picture

Put a link to a cute animal picture inside the parenthesis-->

@jsign jsign changed the title feat(benchmarks): add missing target opcodes feat(benchmark): add missing target opcodes for SMOD, MOD and EXP Apr 1, 2026
@jsign jsign marked this pull request as ready for review April 1, 2026 21:14
@codecov
Copy link
Copy Markdown

codecov bot commented Apr 1, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 86.24%. Comparing base (26c98b9) to head (a9ef100).

Additional details and impacted files
@@               Coverage Diff                @@
##           forks/amsterdam    #2613   +/-   ##
================================================
  Coverage            86.24%   86.24%           
================================================
  Files                  599      599           
  Lines                36984    36984           
  Branches              3795     3795           
================================================
  Hits                 31895    31895           
  Misses                4525     4525           
  Partials               564      564           
Flag Coverage Δ
unittests 86.24% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Copy Markdown
Collaborator

@LouisTsai-Csie LouisTsai-Csie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@LouisTsai-Csie LouisTsai-Csie changed the title feat(benchmark): add missing target opcodes for SMOD, MOD and EXP feat(test-benchmark): add missing target opcodes for SMOD, MOD and EXP Apr 2, 2026
@LouisTsai-Csie LouisTsai-Csie added A-test-benchmark Area: execution_testing.benchmark and tests/benchmark C-feat Category: an improvement or new feature labels Apr 2, 2026
@LouisTsai-Csie LouisTsai-Csie merged commit 8ae9dcc into ethereum:forks/amsterdam Apr 2, 2026
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-test-benchmark Area: execution_testing.benchmark and tests/benchmark C-feat Category: an improvement or new feature

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants