feat(tooling): added a smoke test for devs#2605
feat(tooling): added a smoke test for devs#2605Carsons-Eels wants to merge 1 commit intoethereum:forks/amsterdamfrom
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## forks/amsterdam #2605 +/- ##
================================================
Coverage 86.24% 86.24%
================================================
Files 599 599
Lines 36984 36984
Branches 3795 3795
================================================
Hits 31895 31895
Misses 4525 4525
Partials 564 564
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
danceratopz
left a comment
There was a problem hiding this comment.
Hey @Carsons-Eels I really appreciate the sentiment and have been pondering this one too!
Couple of thoughts:
- I think we should lean into the
eels_base_coveragemarker here, cf #2524, instead of hard-coding a set of tests. This will be a bit slower because it contains more tests. To mitigate, I think it would be worth it to try improve how this marker is applied. It is currently too liberal and applied to all parametrized tests from the output of minimize-tests, but imo we should make the effort to apply it with finer granularity on the parametrized subset. - I would love to add this flag
--generate-all-formatsto get a smoke test for enginex filling and pre-allocation group generation.
|
Just adapted it to the new This was definitely a quick stab at it for my own needs with refactoring. I like your suggestions; if you want to have a quick alignment chat about it DM me Thursday or Tuesday. It would be great to get a couple smoke test configurations in. |
🗒️ Description
Adds a
smokejob tojustthat runs some of the static analysis checks with a minimal test suite. It's intended for quick development validation during big changes such as large refactors without running the full test suite.The smoke suite runs tests from 8 files from Frontier through Amsterdam. I chose tests that were not slow, and that covered as large a set of fragile and critical paths as possible.
Test Coverage
test_all_opcodes.pytest_scenarios.pytest_transaction.pytest_call.pytest_tstorage.pytest_gas.pytest_block_access_lists.pytest_block_access_lists_opcodes.py🔗 Related Issues or PRs
None
✅ Checklist
toxchecks to avoid unnecessary CI fails, see also Code Standards and Enabling Pre-commit Checks:uvx tox -e statictype(scope):.