fix(tests): resolve transition fork blob methods in EIP-4844 conftest#2602
Merged
spencer-tb merged 2 commits intoethereum:forks/amsterdamfrom Mar 31, 2026
Merged
Conversation
Transition forks like `ShanghaiToCancunAtTime15k` inherit from `TransitionBaseClass`, not `BaseFork`, so they lack blob-related methods (`blob_gas_per_blob`, `target_blobs_per_block`, etc.). Chain `.transitions_to()` before each blob method call — a no-op for regular forks, resolves to the target fork for transition forks.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## forks/amsterdam #2602 +/- ##
===================================================
- Coverage 86.35% 86.24% -0.12%
===================================================
Files 599 599
Lines 36904 36984 +80
Branches 3771 3795 +24
===================================================
+ Hits 31868 31895 +27
- Misses 4485 4525 +40
- Partials 551 564 +13
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
spencer-tb
approved these changes
Mar 31, 2026
Contributor
spencer-tb
left a comment
There was a problem hiding this comment.
LGTM! Thanks for catching this :)
spencer-tb
pushed a commit
to spencer-tb/execution-specs
that referenced
this pull request
Mar 31, 2026
…ethereum#2602) * fix(tests): resolve transition fork blob methods in EIP-4844 conftest Transition forks like `ShanghaiToCancunAtTime15k` inherit from `TransitionBaseClass`, not `BaseFork`, so they lack blob-related methods (`blob_gas_per_blob`, `target_blobs_per_block`, etc.). Chain `.transitions_to()` before each blob method call — a no-op for regular forks, resolves to the target fork for transition forks. * ci: trigger CI
spencer-tb
added a commit
to spencer-tb/execution-specs
that referenced
this pull request
Mar 31, 2026
Add .transitions_to() calls for all fork method lookups in the EIP-7918 blob reserve price conftest and spec, matching the pattern from the EIP-4844 conftest fix (ethereum#2602). Transition forks like OsakaToBPO1AtTime15k don't have blob methods directly; they must resolve to the target fork first.
4 tasks
spencer-tb
pushed a commit
to spencer-tb/execution-specs
that referenced
this pull request
Apr 1, 2026
…ethereum#2602) * fix(tests): resolve transition fork blob methods in EIP-4844 conftest Transition forks like `ShanghaiToCancunAtTime15k` inherit from `TransitionBaseClass`, not `BaseFork`, so they lack blob-related methods (`blob_gas_per_blob`, `target_blobs_per_block`, etc.). Chain `.transitions_to()` before each blob method call — a no-op for regular forks, resolves to the target fork for transition forks. * ci: trigger CI
spencer-tb
added a commit
to spencer-tb/execution-specs
that referenced
this pull request
Apr 1, 2026
Add .transitions_to() calls for all fork method lookups in the EIP-7918 blob reserve price conftest and spec, matching the pattern from the EIP-4844 conftest fix (ethereum#2602). Transition forks like OsakaToBPO1AtTime15k don't have blob methods directly; they must resolve to the target fork first.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🗒️ Description
Transition forks like
ShanghaiToCancunAtTime15kinherit fromTransitionBaseClass, notBaseFork, so they lack blob-related methods (blob_gas_per_blob,target_blobs_per_block, etc.). Calling these methods on a transition fork in the EIP-4844 conftest fixtures causes anAttributeError.Fix: chain
.transitions_to()before each blob method call — a no-op for regular forks, resolves to the target fork for transition forks. This is the established pattern used 30+ times across the codebase.This bug is not caught in CI because
test_blob_type_tx_pre_forkis marked@pytest.mark.slowandtox -e py3runs with-m "not slow".🔗 Related Issues or PRs
Blocks:
✅ Checklist
toxchecks to avoid unnecessary CI fails, see also Code Standards and Enabling Pre-commit Checks:uvx tox -e statictype(scope):.Cute Animal Picture