Skip to content

Conversation

@pdobacz
Copy link
Contributor

@pdobacz pdobacz commented Jan 13, 2026

πŸ—’οΈ Description

YMMV but this works for me if I want to fill for chainid other than 1.

πŸ”— Related Issues or PRs

Maybe closes #1394 , please verify. There are two links posted in the description there, the latter is handled, the former I think also seems like should be doable, but I'm not sure if that secretKey is used anywhere at all, please advise I think the latter one is also handled, CI made me do it.

βœ… Checklist

  • All: Ran fast tox
  • All: PR title adheres
  • All: Considered adding an entry to CHANGELOG.md.
  • All: Considered updating the online docs in the ./docs/ directory.
  • All: Set appropriate labels for the changes (only maintainers can apply labels).

@codecov
Copy link

codecov bot commented Jan 13, 2026

Codecov Report

βœ… All modified and coverable lines are covered by tests.
βœ… Project coverage is 86.33%. Comparing base (858336e) to head (15f3de4).
⚠️ Report is 6 commits behind head on forks/amsterdam.

Additional details and impacted files
@@               Coverage Diff                @@
##           forks/amsterdam    #2016   +/-   ##
================================================
  Coverage            86.33%   86.33%           
================================================
  Files                  538      538           
  Lines                34557    34557           
  Branches              3222     3222           
================================================
  Hits                 29835    29835           
  Misses                4148     4148           
  Partials               574      574           
Flag Coverage Ξ”
unittests 86.33% <ΓΈ> (ΓΈ)

Flags with carried forward coverage won't be shown. Click here to find out more.

β˜” View full report in Codecov by Sentry.
πŸ“’ Have feedback on the report? Share it here.

πŸš€ New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • πŸ“¦ JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@pdobacz pdobacz force-pushed the feat/customize-chain-id branch from 75f2a76 to 15f3de4 Compare January 14, 2026 17:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Can eels t8n accept chain_id != 1

1 participant