Skip to content

Conversation

@pdobacz
Copy link
Contributor

@pdobacz pdobacz commented Jan 7, 2026

🗒️ Description

Gas costs of opcodes/precompiles being hardcoded throughout tests makes it harder to change and experiment with. This proposal makes the tests less sensitive to repricing of storage, cold access and some precompiles gas. It is unfortunately not exhaustive.

Would a partial result like this be useful? Feel free to let me know if there are any commits you'd rather drop from the list.

Opening the PR as draft to discuss whether it makes sense to merge at all and to what extent.

🔗 Related Issues or PRs

N/A.

✅ Checklist

  • All: Ran fast tox checks to avoid unnecessary CI fails, see also Code Standards and Enabling Pre-commit Checks:
    uvx tox -e static
  • All: PR title adheres to the repo standard - it will be used as the squash commit message and should start type(scope):.
  • All: Considered adding an entry to CHANGELOG.md.
  • All: Considered updating the online docs in the ./docs/ directory.
  • All: Set appropriate labels for the changes (only maintainers can apply labels).

@codecov
Copy link

codecov bot commented Jan 7, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 86.33%. Comparing base (3ac8ce8) to head (2207680).
⚠️ Report is 7 commits behind head on forks/amsterdam.

Additional details and impacted files
@@               Coverage Diff                @@
##           forks/amsterdam    #1987   +/-   ##
================================================
  Coverage            86.33%   86.33%           
================================================
  Files                  538      538           
  Lines                34557    34561    +4     
  Branches              3222     3222           
================================================
+ Hits                 29835    29839    +4     
  Misses                4148     4148           
  Partials               574      574           
Flag Coverage Δ
unittests 86.33% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

jsign pushed a commit to jsign/execution-specs that referenced this pull request Jan 20, 2026
… `--filter` (ethereum#1987)

Co-authored-by: danceratopz <danceratopz@gmail.com>
jsign pushed a commit to jsign/execution-specs that referenced this pull request Jan 20, 2026
… `--filter` (ethereum#1987)

Co-authored-by: danceratopz <danceratopz@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant