refactor(fw,tests): Unhardcode gas #1987
Draft
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🗒️ Description
Gas costs of opcodes/precompiles being hardcoded throughout tests makes it harder to change and experiment with. This proposal makes the tests less sensitive to repricing of storage, cold access and some precompiles gas. It is unfortunately not exhaustive.
Would a partial result like this be useful? Feel free to let me know if there are any commits you'd rather drop from the list.
Opening the PR as draft to discuss whether it makes sense to merge at all and to what extent.
🔗 Related Issues or PRs
N/A.
✅ Checklist
toxchecks to avoid unnecessary CI fails, see also Code Standards and Enabling Pre-commit Checks:uvx tox -e statictype(scope):.