Allow readers to ignore trailing bytes after declared SSZ bytes - #5511
Open
dapplion wants to merge 2 commits into
Open
Allow readers to ignore trailing bytes after declared SSZ bytes#5511dapplion wants to merge 2 commits into
dapplion wants to merge 2 commits into
Conversation
Contributor
|
Thanks for looking into this @dapplion. I would like to add some cross-client context for discussion, since the implementation has changed after the original report:
|
Member
|
Will merge after at least one developer from each client team has approved this. |
wemeetagain
approved these changes
Aug 5, 2026
jxs
approved these changes
Aug 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Trailing bytes after the declared
nSSZ bytes cannot change the decoded message, but rejecting them requires observing EOF before processing, which adds latency and lets a peer stall a request by holding the stream open. This makes ignoring them permitted.Teku rejects trailing bytes; Lighthouse, Prysm, Lodestar, Nimbus and Grandine accept them.
MAYleaves all six conformant.Related to sigp/lighthouse#9301
Related to sigp/lighthouse#9567