only use modules.yaml from recipe

[albestro]

Fix #274

Changelog:

• fix path for modules.yaml default (continue reading for more details)
• no more default modules.yaml provided
• config:modules deprecated: it can still be specified, but with a warning message
• added consistency check of config:modules and existence of modules.yaml file in recipe
• make modules optional, i.e. do not even copy files when config:modules:false
• doc updates

According to PR51162 the file is still in spack/etc but it has been moved from defaults to defaults/base.

• What to do about pre/post change differences/version compatibilities? (AFAICT [email protected] is post-change)
• Verify why modules.yaml fallback is used when config:modules:false
• Should we switch config:modules default to false? Or should we completely remove it?

[bcumming]

Thanks!

I have one small fix in the docs.

Shall we remove config:modules in another PR? I would be happy to do it in this one.

[albestro]

As suggested by @bcumming, I checked if the modules view was generated or not in the different cases

recipe-without-modules

[daint][ialberto@daint-ln003 recipe-without-modules]$ uenv start ./store.squashfs
(paraview)[daint][ialberto@daint-ln003 recipe-without-modules]$ uenv status
paraview:/user-environment
  ParaView for Alps Grace-Hopper clusters using EGL
  views:
    spack: configure spack upstream
(paraview)[daint][ialberto@daint-ln003 recipe-without-modules]$ ls -l /user-environment/meta/recipe/
total 2
-rw-r--r-- 1 nobody nobody  21 Nov 26 12:25 compilers.yaml
-rw-r--r-- 1 nobody nobody 301 Nov 26 12:25 config.yaml
-rw-r--r-- 1 nobody nobody  91 Nov 26 12:25 environments.yaml
-rw-r--r-- 1 nobody nobody 459 Nov 26 12:25 fake.yaml

recipe-with-modules

[daint][ialberto@daint-ln003 recipe-with-modules]$ uenv start ./store.squashfs
(paraview)[daint][ialberto@daint-ln003 recipe-with-modules]$ uenv status
paraview:/user-environment
  ParaView for Alps Grace-Hopper clusters using EGL
  views:
    spack: configure spack upstream
    modules: activate modules
(paraview)[daint][ialberto@daint-ln003 recipe-with-modules]$ ls -l /user-environment/meta/recipe/
total 4
-rw-r--r-- 1 nobody nobody   21 Nov 26 12:34 compilers.yaml
-rw-r--r-- 1 nobody nobody  372 Nov 26 12:34 config.yaml
-rw-r--r-- 1 nobody nobody   91 Nov 26 12:34 environments.yaml
-rw-r--r-- 1 nobody nobody 1582 Nov 26 12:34 modules.yaml