raft: rename raftLog.nextEnts to raftLog.nextCommittedEnts#14719
Merged
ahrtr merged 1 commit intoetcd-io:mainfrom Nov 11, 2022
Merged
raft: rename raftLog.nextEnts to raftLog.nextCommittedEnts#14719ahrtr merged 1 commit intoetcd-io:mainfrom
ahrtr merged 1 commit intoetcd-io:mainfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## main #14719 +/- ##
==========================================
- Coverage 75.55% 75.53% -0.03%
==========================================
Files 457 457
Lines 37323 37321 -2
==========================================
- Hits 28201 28192 -9
- Misses 7354 7362 +8
+ Partials 1768 1767 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
ahrtr
reviewed
Nov 11, 2022
Also rename hasNextEnts to hasNextCommittedEnts. Also rename maxNextEntsSize to maxNextCommittedEntsSize. Pure refactor. Signed-off-by: Nathan VanBenschoten <nvanbenschoten@gmail.com>
nvb
force-pushed
the
nvanbenschoten/nextCommittedEnts
branch
from
9337120 to
3711fde
Compare
Contributor
Author
|
@ahrtr thanks for the review, this should be good for another look. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Also rename
hasNextEntstohasNextCommittedEnts.Also rename
maxNextEntsSizetomaxNextCommittedEntsSize.Extracted from #14627. cc. @tbg
Pure refactor.
Signed-off-by: Nathan VanBenschoten nvanbenschoten@gmail.com
Please read https://github.com/etcd-io/etcd/blob/main/CONTRIBUTING.md#contribution-flow.