Add debian and rpm packaging#2579
Merged
Merged
Conversation
AmmarAbouZor
reviewed
Jun 8, 2026
AmmarAbouZor
left a comment
Member
There was a problem hiding this comment.
I've run checks using AI agent and got this result back. However, you are the domain expert so it's up to you to decide which of them needs to be fixed if any:
Review Generated by AI:
-
macOS CLI artifact is published unsigned
development/scripts/release_app.py:72,development/scripts/release_app.py:131- The new CLI
.tgzis appended after macOS app signing/notarization andpackage_cli_portable()only copies the raw CLI binary. Since CI uploads all*.tgz, signed macOS releases will now include an unsignedchipmunk-cli@...-darwin*.tgz. Users downloading it with quarantine may be blocked by Gatekeeper. Sign/notarize the CLI artifact on macOS or skip publishing the macOS CLI archive.
-
Linux package directory modes depend on caller umask
development/packaging/linux/packages.py:325make_dir()usesmkdir(parents=True)but onlychmods the final directory. Parent directories created during staging inherit the process umask, so local release builds with restrictive umasks can produce DEB/RPM trees with bad directory modes. Walk and chmod each created directory under the staging root.
Include chipmunk-cli in release workflow Remove README.md from tar release artifact
0a8c351 to
e437d9e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Include chipmunk-cli in release workflow
Remove README.md from tar release artifact
Remove the unused .release file
Add debian and rpm packaging