Skip to content

Add debian and rpm packaging#2579

Merged
itsmesamster merged 3 commits into
esrlabs:masterfrom
itsmesamster:chipmunk_native
Jun 10, 2026
Merged

Add debian and rpm packaging#2579
itsmesamster merged 3 commits into
esrlabs:masterfrom
itsmesamster:chipmunk_native

Conversation

@itsmesamster

Copy link
Copy Markdown
Collaborator

Include chipmunk-cli in release workflow
Remove README.md from tar release artifact
Remove the unused .release file
Add debian and rpm packaging

@AmmarAbouZor AmmarAbouZor left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've run checks using AI agent and got this result back. However, you are the domain expert so it's up to you to decide which of them needs to be fixed if any:

Review Generated by AI:

  1. macOS CLI artifact is published unsigned

    • development/scripts/release_app.py:72, development/scripts/release_app.py:131
    • The new CLI .tgz is appended after macOS app signing/notarization and package_cli_portable() only copies the raw CLI binary. Since CI uploads all *.tgz, signed macOS releases will now include an unsigned chipmunk-cli@...-darwin*.tgz. Users downloading it with quarantine may be blocked by Gatekeeper. Sign/notarize the CLI artifact on macOS or skip publishing the macOS CLI archive.
  2. Linux package directory modes depend on caller umask

    • development/packaging/linux/packages.py:325
    • make_dir() uses mkdir(parents=True) but only chmods the final directory. Parent directories created during staging inherit the process umask, so local release builds with restrictive umasks can produce DEB/RPM trees with bad directory modes. Walk and chmod each created directory under the staging root.

Include chipmunk-cli in release workflow
Remove README.md from tar release artifact
@itsmesamster itsmesamster merged commit 3eb4129 into esrlabs:master Jun 10, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants