Skip to content

Change NUOPC default to unmappedaction=error#548

Open
danrosen25 wants to merge 1 commit into
esmf-org:developfrom
danrosen25:fix/nuopc_unmapped
Open

Change NUOPC default to unmappedaction=error#548
danrosen25 wants to merge 1 commit into
esmf-org:developfrom
danrosen25:fix/nuopc_unmapped

Conversation

@danrosen25
Copy link
Copy Markdown
Member

@danrosen25 danrosen25 commented May 13, 2026 •
edited
Loading

  • Forces end-user to handle unmapped points, which fixes potential incorrect results due to zeroing unmapped cells
  • Non-backwards compatible for NUOPC applications that are not handling unmapped points
  • Previous behavior is replicated by adding :unmappedaction=ignore to NUOPC Connector options in run sequence
  • Other options include adding :extrapmethod=<extrapmethod> or :unmappedaction=ignore:zeroregion=select to Connector options

Notes

  • Expected errors in NUOPC App Prototypes will need to be fixed

@danrosen25
Change NUOPC default to unmappedaction=error
5f719c8 
* Forces end-user to handle unmapped points which fixes potential
  incorrect results due to zeroing unmapped cells
* Non-backwards compatible for NUOPC applications that are not
  handling unmapped points
* Previous behavior is replicated by adding ':unmappedaction=ignore'
  to NUOPC Connector options in run sequence
* Other options include adding ':extrapmethod=<extrapmethod>' or
  ':unmappedaction=ignore:zeroregion=select' to Connector options
@danrosen25 danrosen25 added this to the v09.00.00 milestone May 13, 2026
@danrosen25 danrosen25 requested a review from theurich May 13, 2026 17:48
@danrosen25 danrosen25 self-assigned this May 13, 2026
@danrosen25 danrosen25 added NUOPC non backward compatible Modification breaks backward compatibility (e.g. API changes) labels May 13, 2026
@danrosen25 danrosen25 linked an issue May 13, 2026 that may be closed by this pull request
Change NUOPC default to unmappedAction=error #319
Open
theurich
theurich reviewed May 13, 2026
View reviewed changes
Copy link
Copy Markdown
Member

@theurich theurich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good to me. This will be good to have!

@danrosen25 I just restarted the one CI test combo that was failing. It looked like an unrelated hiccup.

Also, I am looking at the nuopc-apps-protos that need fixing. Will let you know how that goes in a bit.

@theurich theurich mentioned this pull request May 13, 2026
Open
@theurich
Copy link
Copy Markdown
Member

theurich commented May 13, 2026

@danrosen25 we might need this available via esmf-org/esmf branch. This way I will be able to use it in testing using the updated nuopc-app-prototypes workflow to test my proto updates.

@danrosen25
Copy link
Copy Markdown
Member Author

danrosen25 commented May 14, 2026

@theurich
I pushed it to esmf-org/esmf
https://github.com/esmf-org/esmf/tree/fix/nuopc_unmapped

@theurich
Copy link
Copy Markdown
Member

theurich commented May 14, 2026

@danrosen25 thanks!

Adjustments to this change for nuopc-app-prototypes are ready to go under esmf-org/nuopc-app-prototypes#14. Just waiting for esmf-org/nuopc-app-prototypes#13 to come in first so I can kick off a GH test run.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@theurich theurich theurich left review comments

Assignees

@danrosen25 danrosen25

Labels

non backward compatible Modification breaks backward compatibility (e.g. API changes) NUOPC

Projects

None yet

Milestone

v09.00.00

Development

Successfully merging this pull request may close these issues.

Change NUOPC default to unmappedAction=error

2 participants

@danrosen25 @theurich