Skip to content

Add checking of transformed values in storage fuzzing#13230

Merged
eivindjahren merged 3 commits intoequinor:mainfrom
eivindjahren:update_storage_fuzzing
Apr 1, 2026
Merged

Add checking of transformed values in storage fuzzing#13230
eivindjahren merged 3 commits intoequinor:mainfrom
eivindjahren:update_storage_fuzzing

Conversation

@eivindjahren
Copy link
Copy Markdown
Contributor

@eivindjahren eivindjahren commented Mar 31, 2026 •
edited
Loading

  • PR title captures the intent of the changes, and is fitting for release notes.
  • Added appropriate release note label
  • Commit history is consistent and clean, in line with the contribution guidelines.
  • Make sure unit tests pass locally after every commit (git rebase -i main --exec 'just rapid-tests')

When applicable

  • When there are user facing changes: Updated documentation
  • New behavior or changes to existing untested code: Ensured that unit tests are added (See Ground Rules).
  • Large PR: Prepare changes in small commits for more convenient review
  • Bug fix: Add regression test for the bug
  • Bug fix: Add backport label to latest release (format: 'backport release-branch-name')

@eivindjahren eivindjahren self-assigned this Mar 31, 2026
@eivindjahren eivindjahren requested a review from Copilot March 31, 2026 07:58
@eivindjahren eivindjahren added the release-notes:build-system PR containing only build system changes label Mar 31, 2026
@eivindjahren eivindjahren moved this to Ready for Review in SCOUT Mar 31, 2026
Copilot AI reviewed Mar 31, 2026
View reviewed changes
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds an additional Hypothesis state-machine rule to the local storage fuzzing tests to exercise/verify behavior around loading transformed parameter values from storage.

Changes:

  • Add a new state-machine @rule that calls load_parameters(..., transformed=True) and asserts the returned data matches expectations after applying parameter transformations.

@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Mar 31, 2026 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.31%. Comparing base (9e978e7) to head (0a509c4).
⚠️ Report is 4 commits behind head on main.
✅ All tests successful. No failed tests found.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main   #13230      +/-   ##
==========================================
- Coverage   90.32%   90.31%   -0.02%     
==========================================
  Files         453      453              
  Lines       31330    31330              
==========================================
- Hits        28300    28296       -4     
- Misses       3030     3034       +4
Flag Coverage Δ
cli-tests 37.65% <ø> (ø)
fuzz 44.60% <ø> (+<0.01%) ⬆️
gui-tests 67.43% <ø> (-0.01%) ⬇️
performance-and-unit-tests 77.76% <ø> (-0.02%) ⬇️
test 46.42% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.
see 1 file with indirect coverage changes

@codspeed-hq
Copy link
Copy Markdown

codspeed-hq bot commented Mar 31, 2026 •
edited
Loading

Merging this PR will not alter performance

✅ 36 untouched benchmarks

Comparing eivindjahren:update_storage_fuzzing (0a509c4) with main (376ed8c)

Open in CodSpeed

@eivindjahren eivindjahren force-pushed the update_storage_fuzzing branch 4 times, most recently from 6639da5 to 71631c4 Compare April 1, 2026 07:09
xjules
xjules reviewed Apr 1, 2026
View reviewed changes
tests/ert/unit_tests/storage/test_local_storage.py
storage_ensemble.save_parameters(
pl.DataFrame(
{p.name: [scalar_value]},
schema={p.name: pl.Float64},
Copy link
Copy Markdown
Contributor

@xjules xjules Apr 1, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"realization" column should be part of schema.

xjules
xjules approved these changes Apr 1, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@xjules xjules left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a small comment, but otherwise looks fine to me! 🚀

@github-project-automation github-project-automation bot moved this from Ready for Review to Reviewed in SCOUT Apr 1, 2026
@xjules
Copy link
Copy Markdown
Contributor

xjules commented Apr 1, 2026

There is a typo in the first commit message and squash the second one.

@eivindjahren
Fix an issue with parameters in storage model test
01b1cb3 
Parameters would not be set correctly in TestStorage.
This fixes that and expands parameters generated to
GenKw and Surface.
@eivindjahren
Add transformed parameters to model test
22c3af1
@eivindjahren
Add fetching of parameter groups part of model test
0a509c4 
This also necessitates weaking/updating of some other assertions.
@eivindjahren eivindjahren force-pushed the update_storage_fuzzing branch from 71631c4 to 0a509c4 Compare April 1, 2026 12:40
@eivindjahren eivindjahren merged commit 4d0ca2c into equinor:main Apr 1, 2026
44 checks passed
@github-project-automation github-project-automation bot moved this from Reviewed to Done in SCOUT Apr 1, 2026
@eivindjahren eivindjahren deleted the update_storage_fuzzing branch April 1, 2026 13:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Copilot left review comments

@xjules xjules xjules approved these changes

Assignees

@eivindjahren eivindjahren

Labels

release-notes:build-system PR containing only build system changes

Projects

SCOUT
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@eivindjahren @codecov-commenter @xjules