Filter NaN parameter rows in EnIF update#13202
Draft
larsevj wants to merge 1 commit intoequinor:mainfrom
Draft
Conversation
Surface and field parameters commonly have NaN for inactive grid cells. When EnIF stacks all parameters into a joint matrix, these NaN values corrupt boost_linear_regression (np.argmax treats NaN as maximum) and propagate through StandardScaler, contaminating whichever parameter sits at index 0 in the joint matrix.
f6b20ac to
a38553e
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #13202 +/- ##
==========================================
- Coverage 90.26% 90.24% -0.03%
==========================================
Files 453 453
Lines 31301 31327 +26
==========================================
+ Hits 28255 28272 +17
- Misses 3046 3055 +9
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Surface and field parameters commonly have NaN for inactive grid cells. When EnIF stacks all parameters into a joint matrix, these NaN values corrupt boost_linear_regression (np.argmax treats NaN as maximum) and propagate through StandardScaler, contaminating whichever parameter sits at index 0 in the joint matrix.
Issue
Resolves #my_issue
Approach
Short description of the approach
(Screenshot of new behavior in GUI if applicable)
git rebase -i main --exec 'just rapid-tests')When applicable