Add config for update strategy for parameter types#13048
Add config for update strategy for parameter types#13048frode-aarstad wants to merge 4 commits intoequinor:mainfrom
Conversation
077c49b to
1349de4
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #13048 +/- ##
==========================================
- Coverage 90.55% 90.53% -0.02%
==========================================
Files 454 454
Lines 31233 31249 +16
==========================================
+ Hits 28282 28292 +10
- Misses 2951 2957 +6
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
…rstad/ert into add-strategy-for-parameter-type
There was a problem hiding this comment.
Pull request overview
Adds support in AnalysisConfig for configuring a default update strategy per parameter type via ANALYSIS_SET_VAR PARAMETERS ..., aligning with issue #13027’s requested configuration capability.
Changes:
- Parse
ANALYSIS_SET_VAR PARAMETERS <PARAMETER_TYPE> <STRATEGY>into a newAnalysisConfig.parameter_settingsstructure. - Add validation errors for unknown parameter types and strategy names.
- Add unit tests covering successful parsing and validation failures.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
src/ert/config/analysis_config.py |
Introduces ParameterSettings and parsing/validation of ANALYSIS_SET_VAR PARAMETERS ... into AnalysisConfig. |
tests/ert/unit_tests/config/test_analysis_config.py |
Adds unit tests for the new parameter strategy configuration parsing and validation. |
| ANALYSIS_SET_VAR PARAMETERS FIELD DISTANCE | ||
| ANALYSIS_SET_VAR PARAMETERS GEN_KW ADAPTIVE | ||
|
|
||
|
|
There was a problem hiding this comment.
I need some help filling out the docs here
|
We will need to link it to the storage (maybe parameter configs?) and currently we don't have a consensus on whether it should be the full analysis config info (and thus dropping the analysis config entirely) or just to have a name of the |
Issue
Resolves #13027
Approach
Short description of the approach
(Screenshot of new behavior in GUI if applicable)
git rebase -i main --exec 'just rapid-tests')When applicable