Fix plotter not doing output transformation for fields#13046
Fix plotter not doing output transformation for fields#13046jonathan-eq wants to merge 2 commits intoequinor:mainfrom
Conversation
88ac6b3 to
7ae4ac7
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #13046 +/- ##
==========================================
+ Coverage 90.55% 90.63% +0.08%
==========================================
Files 454 454
Lines 31233 31257 +24
==========================================
+ Hits 28282 28330 +48
+ Misses 2951 2927 -24
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
| 1,9,7,0,1.9924866,1.2448008,1.3364313,1.8939083,1.4918013,1.2913821,3.2627063,1.2758563,1.8078659,3.1968975,2.9968414,2.094899,1.2425833,1.046571,2.3222582,3.3161533,1.4485201,2.1437743,3.65806,1.2970147,4.3399296,2.8092623,2.0973995,1.7622559,2.2120671,3.9166331,1.887745,2.6658251,6.4080195,2.12168,1.516806,2.5737936,3.6258926,4.4484897,2.460406,1.6551435,2.2805028,1.0974382,2.2530558,3.391804,8.809429,1.03762,1.3139108,0.9963665,2.0279546,1.6954283,1.4813887,1.0478696,5.9722505,2.5740666,3.5383053,1.7016975,0.80627257,4.151332,1.6511589,4.8893304,2.2807758,3.60988,1.785634,1.989986,1.6913627,1.0088731,2.9235058,2.960252,5.1630483,2.5700543,1.6942575,1.5174396,2.109247,3.16763,2.825092,1.929826,4.284215,0.91266125,2.8563476,3.5471928,1.5584488,1.7936947,6.625857,1.1326327,1.5749266,4.0393653,1.2379278,1.7305601,2.5724685,1.6995614,2.7445338,2.1370447,8.185272,1.6956496,2.9313593,4.971274,1.6843693,3.2531133,2.2534804,5.37146,2.1026094,1.5194488,2.6197934,1.2362511 | ||
| 1,9,8,0,1.519316,1.1170563,1.3191301,1.8287637,0.8445647,1.1832807,3.8449137,1.0597844,1.266503,3.709399,3.5392172,1.9935373,0.95990753,1.0756137,2.9414015,2.801209,1.3429146,2.4724264,4.1140018,1.3861024,5.2416553,2.54728,2.2008758,1.8571908,2.2288058,4.2427826,1.6253165,1.9426938,5.9123483,1.7368479,1.2947766,1.6047903,4.2141657,4.478965,2.642515,1.3283513,2.05267,1.0689934,2.6082006,3.941263,16.139833,0.969987,1.4010037,0.68381166,1.5194485,2.457116,1.2899644,0.5484272,7.0536447,3.210669,4.0324063,1.9135045,0.62207633,3.52837,1.6378375,8.448901,2.3286092,3.7769504,1.8305802,1.6918559,1.630639,0.3715163,2.848235,3.75566,6.356136,2.2033956,0.9818593,1.313794,1.9988031,2.435791,2.3943512,1.8404824,3.4554226,1.0383776,2.590415,3.5938325,1.5069811,1.3147962,13.088825,1.153477,1.5045606,5.2592206,1.3522421,2.237077,2.7204893,1.1553868,2.3087993,2.6730924,9.14313,1.3511031,1.9754691,4.614357,1.4341246,2.478172,2.1144285,4.834199,2.0699515,1.286259,2.9929955,1.161261 | ||
| 1,9,9,0,1.4505374,1.2234423,1.3870528,1.7310959,0.605651,1.1829213,4.5466776,1.0480518,1.1074064,4.994191,4.327876,2.2013392,0.89196306,1.3134803,3.6669307,2.3992043,1.4377985,2.605805,4.456617,1.8832092,6.1052866,2.426986,2.4692128,2.0666962,2.3405204,4.3301997,1.7169651,1.5599965,5.0874486,1.4464412,1.3067743,1.1807808,4.86655,3.5882313,2.9225576,1.3120534,2.0123634,1.1912904,3.0662024,4.338318,18.24469,1.0377995,1.6450194,0.65558803,1.3022324,5.2625675,1.2849607,0.30012935,7.999643,4.248778,4.1121387,2.6626103,0.6855117,3.3284128,1.6514463,12.215427,2.2251465,4.0105243,2.2317345,1.6241708,1.8480867,0.13087375,2.7363486,4.745166,6.6134076,2.3422132,0.5142687,1.3317283,1.9393362,2.082555,2.0668378,1.9301442,2.8903682,1.4558895,2.6963766,3.101347,1.9397471,1.1087704,18.707817,1.4566444,1.6333327,5.7030525,1.67133,2.9328575,2.7934878,1.0274256,1.88322,3.6616523,6.3204618,1.2055275,1.6512243,4.33969,1.3311565,1.8836215,2.3433242,3.5786376,1.7898686,1.0216241,3.223098,1.2414327 | ||
| 0,0,0,0,-0.45128956,0.6359305,0.31971008,0.15912634,0.26441252,-1.5067551,0.19940418,-0.6273222,-1.8112311,-0.98846304,-2.5922923,1.1046896,0.6088842,1.0970626,0.9617416,-1.425186,-0.025482,-0.2533205,-0.4370324,0.083672516,0.19681759,0.75564015,-0.43226784,-0.2592557,0.79947585,0.13633746,-1.3614875,0.07073424,-0.8759892,-0.64925057,0.54853773,0.45040193,1.6615068,-0.5060836,0.7181978,-0.8161225,-0.606519,-0.10174353,1.4630238,-0.45877624,-0.7824115,-0.26084945,0.8100218,0.17345706,1.4266522,-1.571683,-0.1684459,-0.10552673,0.6619921,1.7829435,-1.1207912,-0.6201263,0.50440997,0.15162805,0.066805705,0.12402303,0.50066864,0.16952482,-1.1843693,1.1292591,-0.2670285,-1.0059767,-1.0755782,1.9820801,-1.5122898,0.57106966,0.116097644,-1.1196843,1.9068617,1.4822713,0.48954543,0.21121423,-0.64297384,-1.2953808,1.4727722,-1.0376508,0.9546323,0.2996636,0.7039526,0.4689803,-0.80212224,1.0682565,0.57377064,-0.41423634,-2.2091668,-0.19266267,-0.80787724,-0.07804787,-1.4398092,-0.058176495,1.3291898,1.1796715,-1.8868037,1.7383654,0.38713235,0.10787245,-0.076336645,0.15371026,-0.6938983,1.1325916 |
There was a problem hiding this comment.
ln(0.6368) = -0.4512, so this checks out.
6ded476 to
4d32b61
Compare
This is needed to get the correct values in the plotter. The forward model itself manually does the exponential transformation, but this wasn't showing in the plotter. This commit also updated the mpl images in tests, and test snapshots.
4d32b61 to
2fc3a00
Compare
|
@larsevj and I discussed this, and we are not sure what is the expected behavior for the plotting. Should we plot with the transformation, or without. Maybe we should even do a checkbox to toggle between them. Maybe @dafeda or @oyvindeide knows. |
I suggest talking to users. Perhaps ask in #ert-users as a start. |
Given that we plot only transformed values for scalar parameters I think this should be the default here as well (in case there is a transformation specified ofc). |
Issue
While doing #12967 I noticed plotting mean values for conductivity was in the negatives when running heat_equation. This is not possible, and it turned out we dont do transformations when plotting fields.
Approach
Short description of the approach
(Screenshot of new behavior in GUI if applicable)
git rebase -i main --exec 'just rapid-tests')When applicable