Skip to content

Add timeout to bsub command call#12983

Draft
berland wants to merge 2 commits intoequinor:mainfrom
berland:bsub_timeout
Draft

Add timeout to bsub command call#12983
berland wants to merge 2 commits intoequinor:mainfrom
berland:bsub_timeout

Conversation

@berland
Copy link
Copy Markdown
Contributor

@berland berland commented Feb 26, 2026

Issue
Resolves #12973

Approach
asyncio timeout

  • PR title captures the intent of the changes, and is fitting for release notes.
  • Added appropriate release note label
  • Commit history is consistent and clean, in line with the contribution guidelines.
  • Make sure unit tests pass locally after every commit (git rebase -i main --exec 'just rapid-tests')

When applicable

  • When there are user facing changes: Updated documentation
  • New behavior or changes to existing untested code: Ensured that unit tests are added (See Ground Rules).
  • Large PR: Prepare changes in small commits for more convenient review
  • Bug fix: Add regression test for the bug
  • Bug fix: Add backport label to latest release (format: 'backport release-branch-name')

This makes it possible to reason about failures for Ert, however
testing shows it is very hard to obtain stdout/stderr from the hanging
bsub process in case there is anything interesting printed there.
@berland berland marked this pull request as draft February 26, 2026 12:52
@berland berland changed the title Bsub timeout Add timeout to bsub command call Feb 26, 2026
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Feb 26, 2026

Codecov Report

❌ Patch coverage is 45.45455% with 6 lines in your changes missing coverage. Please review.
✅ Project coverage is 90.32%. Comparing base (3cbbcc9) to head (dff91e8).
⚠️ Report is 4 commits behind head on main.
✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
src/ert/scheduler/driver.py 45.45% 6 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #12983      +/-   ##
==========================================
+ Coverage   90.16%   90.32%   +0.16%     
==========================================
  Files         447      448       +1     
  Lines       31057    31011      -46     
==========================================
+ Hits        28002    28011       +9     
+ Misses       3055     3000      -55     
Flag Coverage Δ
cli-tests 36.91% <18.18%> (+0.06%) ⬆️
gui-tests 67.72% <18.18%> (+0.14%) ⬆️
performance-and-unit-tests 76.98% <45.45%> (+0.14%) ⬆️
test 46.09% <18.18%> (+0.09%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

A hanging bsub command will hang Ert

2 participants