(fix) Handled the case of passing a function that returns a date to the MaxDate decorator#112
Open
adelbke wants to merge 2 commits intoepiphone:masterfrom
Open
(fix) Handled the case of passing a function that returns a date to the MaxDate decorator#112adelbke wants to merge 2 commits intoepiphone:masterfrom
adelbke wants to merge 2 commits intoepiphone:masterfrom
Conversation
…he MaxDate decorator
…the MinDate decorator
Author
|
Any Updates on this @epiphone ? |
epiphone
requested changes
Feb 9, 2025
| ], | ||
| }), | ||
| [cv.MIN_DATE]: (meta) => { | ||
| const description = typeof meta.constraints[0] === 'function' ? `After a date computed dynamically` : `After ${meta.constraints[0]}`; |
Owner
There was a problem hiding this comment.
Suggested change
| const description = typeof meta.constraints[0] === 'function' ? `After a date computed dynamically` : `After ${meta.constraints[0]}`; | |
| const description = typeof meta.constraints[0] === 'function' ? `After a date computed dynamically` : `After ${meta.constraints[0].toJSON()}`; |
| } | ||
| }, | ||
| [cv.MAX_DATE]: (meta) => { | ||
| const description = typeof meta.constraints[0] === 'function' ? `Before a date computed dynamically` : `Before ${meta.constraints[0]}`; |
Owner
There was a problem hiding this comment.
Suggested change
| const description = typeof meta.constraints[0] === 'function' ? `Before a date computed dynamically` : `Before ${meta.constraints[0]}`; | |
| const description = typeof meta.constraints[0] === 'function' ? `Before a date computed dynamically` : `Before ${meta.constraints[0].toJSON()}`; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I tried to use the library in an app that tried to validate a date field, ensuring the date is in the past (before
Date.now()).It failed because the library tried to run toJSON() on a function and now I am trying to push a fix for that use case.
It just replaces the description of the field with this description
Before a date computed dynamically.Did the same for the MinDate decorator as well.