Conversation
kentcdodds
left a comment
There was a problem hiding this comment.
Looks good to me. Thanks a lot!
|
Just a note that that project is in alpha status, and says it could have breaking changes. Does anyone know if these changes are likely to be significant enough to cause a significant rewrite? I'm guessing probably not or you wouldn't have merged |
The biggest rewrite was when we switched from Remix to the React Router framework due to the lack of an SDK at the time. Now that the React Router SDK is available, it closely resembles how the Remix SDK was used. Personally, I don’t expect another major rewrite, as most logic is encapsulated within the SDK, and other SDKs follow a similar pattern. I see the alpha status as a reminder to be cautious with updates and pay close attention to the details. |
Official Sentry SDK for React Router Framework is out.
https://www.npmjs.com/package/@sentry/react-router
Test Plan
Checklist
Screenshots