upload source maps during build step#1012
Merged
kentcdodds merged 1 commit intoepicweb-dev:mainfrom May 22, 2025
Merged
Conversation
kentcdodds
approved these changes
May 22, 2025
Member
kentcdodds
left a comment
kentcdodds
left a comment
There was a problem hiding this comment.
Oh nice. Thank you! Good improvement on the deploy command too. Thanks!
mohammedzamakhan
referenced
this pull request
in mohammedzamakhan/epic-startup
Aug 4, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Now that the image is built in the
Build Containerstep instead of theDeploystep, we need to include the sentry auth token in theBuild Containerstep.Test Plan
I have tested this in production on our server. The source map is uploaded to sentry and referenced by a hash of the file, so you can upload as many source maps as you want, and they will not interfere with the source map in production.
Screenshots
Before
After