Improve vite development server config#1007
Merged
kentcdodds merged 2 commits intomainfrom May 8, 2025
Merged
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR improves the Vite development server configuration by adjusting middleware settings and port assignment logic, ensuring the custom server runs with the correct appType and handles port collisions as expected. Key changes include:
- Refining the server startup logic to determine and set the appropriate port.
- Configuring Vite with the custom appType to bypass unnecessary HTML transformation.
- Updating the react-router-devtools dependency and adding a request filter in mocks.
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| tests/mocks/index.ts | Adds a filter to ignore custom requests from react-router-devtools. |
| server/index.ts | Updates Vite dev server configuration with port determination and appType. |
| package.json | Updates the react-router-devtools dependency version. |
mohammedzamakhan
referenced
this pull request
in mohammedzamakhan/epic-startup
Aug 4, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There are a few things these PR aims to achieve:
Test Plan
Should work the same as before:
Checklist
Screenshots