Conversation
phlax
force-pushed
the
ci-envoy-sync
branch
7 times, most recently
from
0d9e9b6 to
a044aeb
Compare
Signed-off-by: Ryan Northey <[email protected]>
jpeach
left a comment
jpeach
left a comment
There was a problem hiding this comment.
I think I vaguely get the gist of what this is doing, but explaining it all in comments in the workflow yaml would be pretty helpful :)
| commit_changes | ||
| if [[ -z "$NO_COMMIT_CHANGES" ]]; then | ||
| commit_changes | ||
| fi |
There was a problem hiding this comment.
While you are here, remove the unused GO_TARGETS and IMPORT_BASE variables?
|
This pull request has been automatically marked as stale because it has not had activity in the last 30 days. It will be closed in 7 days if no further activity occurs. Please feel free to give a status update now, ping for review, or re-open when it's ready. Thank you for your contributions! |
|
This pull request has been automatically closed because it has not had activity in the last 37 days. Please feel free to give a status update now, ping for review, or re-open when it's ready. Thank you for your contributions! |
|
apologies for delay - i will follow up on this - just been busy with some other stuff |
|
This pull request has been automatically marked as stale because it has not had activity in the last 30 days. It will be closed in 7 days if no further activity occurs. Please feel free to give a status update now, ping for review, or re-open when it's ready. Thank you for your contributions! |
|
ill come back to this once envoy release is out of the way |
|
@jpeach wanna try and get this in? |
3 participants
No description provided.