Skip to content

ci: fix ACTIONS_STEP_DEBUG not working #8517

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
zirain wants to merge 1 commit into
base: main
Choose a base branch
from
Open

ci: fix ACTIONS_STEP_DEBUG not working #8517

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions .github/workflows/build_and_test.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -182,6 +182,7 @@ jobs:
IP_FAMILY: ${{ matrix.target.ipFamily }}
KUBE_DEPLOY_PROFILE: ${{ matrix.target.profile }}
E2E_GATEWAY_API_CHANNEL: ${{ matrix.target.gwapiChannel }}
ENABLE_COLLECT_AND_DUMP: ${{ runner.debug == '1' }}
run: make conformance

e2e-test:
Expand Down Expand Up @@ -245,6 +246,7 @@ jobs:
E2E_BACKEND_UPGRADE_QPS: "2000"
# Cluster trust bundle reach beta in v1.33, so we can enable it for v1.33 and later.
ENABLE_CLUSTER_TRUST_BUNDLE: ${{ startsWith(matrix.target.version, 'v1.33') }}
ENABLE_COLLECT_AND_DUMP: ${{ runner.debug == '1' }}
run: make e2e

benchmark-test:
Expand Down Expand Up @@ -293,6 +295,7 @@ jobs:
env:
IMAGE_PULL_POLICY: IfNotPresent
CUSTOM_CNI: "true"
ENABLE_COLLECT_AND_DUMP: ${{ runner.debug == '1' }}
run: make resilience

publish:
Expand Down
4 changes: 2 additions & 2 deletions test/e2e/tests/utils.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -702,8 +702,8 @@ type LokiQueryResponse struct {
// CollectAndDump collects and dumps the cluster data for troubleshooting and log.
// This function should be call within t.Cleanup.
func CollectAndDump(t *testing.T, rest *rest.Config) {
if os.Getenv("ACTIONS_STEP_DEBUG") != "true" {
tlog.Logf(t, "Skipping collecting and dumping cluster data, set ACTIONS_STEP_DEBUG=true to enable it")
if os.Getenv("ENABLE_COLLECT_AND_DUMP") != "true" {
tlog.Logf(t, "Skipping collecting and dumping cluster data, set ENABLE_COLLECT_AND_DUMP=true to enable it")
return
}
dumpedNamespaces := []string{"envoy-gateway-system"}
Expand Down