feat: add support for retry budget in BackendTrafficPolicy#8457
Open
zirain wants to merge 9 commits intoenvoyproxy:mainfrom
Open
feat: add support for retry budget in BackendTrafficPolicy#8457zirain wants to merge 9 commits intoenvoyproxy:mainfrom
zirain wants to merge 9 commits intoenvoyproxy:mainfrom
Conversation
✅ Deploy Preview for cerulean-figolla-1f9435 ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #8457 +/- ##
==========================================
- Coverage 74.16% 74.10% -0.07%
==========================================
Files 242 242
Lines 37603 37573 -30
==========================================
- Hits 27889 27842 -47
- Misses 7773 7786 +13
- Partials 1941 1945 +4 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
zhaohuabing
reviewed
Mar 12, 2026
|
|
||
| // RetryBudget provides settings for retry budget, which limits the number of retries in a given percentage. | ||
| // +optional | ||
| RetryBudget *RetryBudget `json:"retryBudget,omitempty"` |
Member
There was a problem hiding this comment.
Should RetryBudget and MaxParallelRetries be mutually exclusive?
Member
Author
There was a problem hiding this comment.
Envoy doesn't reject the configuration, but RetryBudget take precedence.
Member
Author
There was a problem hiding this comment.
MaxParallelRetries have default value of 1024:
// The maximum number of parallel retries that Envoy will make to the referenced backend defined within a xRoute rule.
//
// +kubebuilder:validation:Minimum=0
// +kubebuilder:validation:Maximum=4294967295
// +kubebuilder:default=1024
// +optional
MaxParallelRetries *int64 `json:"maxParallelRetries,omitempty"`
Maybe we should just add notes on RetryBudget?
Signed-off-by: zirain <[email protected]>
Signed-off-by: zirain <[email protected]>
Signed-off-by: zirain <[email protected]>
Signed-off-by: zirain <[email protected]>
Signed-off-by: zirain <[email protected]>
Signed-off-by: zirain <[email protected]>
Signed-off-by: zirain <[email protected]>
Signed-off-by: zirain <[email protected]>
Signed-off-by: zirain <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add retry budget support in BackendTrafficPolicy to represent retry circuit breakers as a percent of active traffic instead of a static maxRetries circuit breaker values.