Open
Conversation
✅ Deploy Preview for cerulean-figolla-1f9435 canceled.
|
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #8173 +/- ##
==========================================
+ Coverage 73.58% 73.71% +0.13%
==========================================
Files 242 242
Lines 37003 37076 +73
==========================================
+ Hits 27228 27331 +103
+ Misses 7856 7825 -31
- Partials 1919 1920 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
Author
|
/retest |
Contributor
Author
|
/retest |
1 similar comment
Contributor
Author
|
/retest |
arkodg
reviewed
Feb 8, 2026
Contributor
Author
|
/retest |
Contributor
Author
|
/retest |
Signed-off-by: jukie <[email protected]>
Signed-off-by: jukie <[email protected]>
nareddyt
approved these changes
Feb 19, 2026
| } | ||
| } | ||
|
|
||
| // Check targetSelectors (label-based targeting) |
Contributor
There was a problem hiding this comment.
I'm not familiar with targetSelectors, but can they target specific route rules or specific listeners in a gateway?
Contributor
Author
There was a problem hiding this comment.
No they can't target specific rules, it's just a label selector for Kubernetes resources + group/kind matching.
Signed-off-by: jukie <[email protected]>
Signed-off-by: jukie <[email protected]>
Signed-off-by: jukie <[email protected]>
f177014 to
f991418
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Adds implementation for BTP-level RoutingType field
Which issue(s) this PR fixes:
Fixes #7926
Release Notes: Yes