[FBZ-10505] Switch puma to phased-restart for hot restart#141
Open
rupikakapoor wants to merge 2 commits intonext-releasefrom
Open
[FBZ-10505] Switch puma to phased-restart for hot restart#141rupikakapoor wants to merge 2 commits intonext-releasefrom
rupikakapoor wants to merge 2 commits intonext-releasefrom
Conversation
paulasaurus
suggested changes
Nov 14, 2022
paulasaurus
left a comment
There was a problem hiding this comment.
On line 46 please update "hot deploy" to "phased-restart deploy".
Then we also need to confirm what impact the extended amount of time required by a phased-restart has on the deploy process, in terms of it waiting for the restart to complete or not.
Updated Message to mention phased-restart instead of hot restart
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of your patch
Fix puma restart on deploy cause downtime
Recommended Release Notes
Fixed issue where puma restart on deploy cause downtime
Estimated risk
High
Components involved
All clients who use Puma as application stack
Dependencies
ey-puma
Description of testing done
Create v7 environment with puma
Boot Environment.
Run application deployment and monitor for application uptime while Application deployment at
Restarting app serversstep.QA Instructions
Create v7 environment with puma
Boot Environment.
Run application deployment and monitor for application uptime while Application deployment at
Restarting app serversstep.