Conversation
|
The title of this post is truncated, and I can't easily view the full text of it in the github interface. |
kriskowal
changed the title
rekmarks
approved these changes
Jan 26, 2026
packages/ocapn-noise/src/bindings.js
Outdated
Comment on lines
343
to
347
| if (code === 7) { | ||
| throw new Error( | ||
| 'OCapN Noise Protocol SYN intended for different responder', | ||
| ); | ||
| } else if (code === 1) { |
Contributor
There was a problem hiding this comment.
nit: Numerically out of order
kriskowal
force-pushed
the
kriskowal-ocapn-noise-relayable
branch
from
f13bc7e to
a1de705
Compare
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change prepares the experimental OCapN Noise Protocol cryptography so that a relay can see the expected responder’s public key in plain text and use that to route. This will likely limit the use of this cryptography to connection hints specifically denoting relays, and create an obligation to communicate to the user that this kind of connection hint reveals the key of the recipient, and Tor’s right there if you need to hide that information better.
Regardless, I expect most OCapN clients will stand for multiple public keys, one for each profile, and this feature is necessary to complete a handshake on such a peer.