Don't include memory tracing callback in INCOMING_MODULE_JS_API by default. NFC#26363
Merged
sbc100 merged 1 commit intoemscripten-core:mainfrom Feb 27, 2026
Merged
Don't include memory tracing callback in INCOMING_MODULE_JS_API by default. NFC#26363sbc100 merged 1 commit intoemscripten-core:mainfrom
sbc100 merged 1 commit intoemscripten-core:mainfrom
Conversation
Member
|
So the reason that the codesize gets bigger is because we now emit code that checks for the presence of those APIs before using them? |
Collaborator
Author
Its only in debug builds where we emit code to catch incorrect usage |
dschuff
approved these changes
Feb 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These are only ever used by EMSCRIPTEN_TRACING so we know exactly when to include them.
I noticed this while reviewing #26175