feat: NewOpenAPIService OASVersion dispatch + parameter format support - #126
Merged
Merged
Conversation
- NewOpenAPIService now dispatches based on Config.OASVersion
- Address PR review feedback for error handling and feature parity
- Add parameter type/format support using oastools v1.33.0 WithParamFormat
- Achieves feature parity with legacy BuildSwagger for parameter format handling
- Upgrade oastools dependency to v1.33.0
- Add formatBinary constant to satisfy goconst linter
The parameter format feature fills a gap where param.DataFormat("date") was
previously ignored by the oastools builder path. Now formats like "uuid",
"date", "date-time", and "int64" are properly propagated to the OpenAPI spec.
🤖 Generated with [Claude Code](https://claude.com/claude-code)
Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
This PR is a follow-up to PR#125 which introduced the oastools builder integration. It addresses feedback from the maintainer regarding
NewOpenAPIServicebehavior and adds parameter format support that achieves feature parity with the legacyBuildSwaggerpath.Summary
NewOpenAPIService Enhancement
NewOpenAPIServicenow dispatches based onConfig.OASVersion:BuildOAS3BuildOAS2BuildSwaggerParameter Format Support
param.DataFormat()using oastools v1.33.0WithParamFormatCode Quality Improvements
BuildOAS2/BuildOAS3now callConfig.Validate()to catch configuration errors earlybuildResponseOptionshelperformatBinaryconstant to satisfy goconst linterChanges
WithParamFormatinmapParameter()functionTest plan
🤖 Generated with Claude Code