Skip to content

Update images for about page, refresh the layout#1960

Open
Mattsi-Jansky wants to merge 16 commits intoemfcamp:mainfrom
Mattsi-Jansky:about-page-2026
Open

Update images for about page, refresh the layout#1960
Mattsi-Jansky wants to merge 16 commits intoemfcamp:mainfrom
Mattsi-Jansky:about-page-2026

Conversation

@Mattsi-Jansky
Copy link
Copy Markdown
Contributor

@Mattsi-Jansky Mattsi-Jansky commented Apr 9, 2026

image

All images comply with photo policy, by my judgement at least. Welcome to review and discuss if you see any issues. Almost all images were sourced from https://cloud.orga.emfcamp.org, one comes from a village's photo album.

Other notes:

  • All images are optimised for web, i.e. compressed jpegs and resolution reduced to 1080p.
    • Where images are displayed in reduced size I generated reduced resolution thumbnails which drops file size ~80%, but the user can click to view the 1080p version.
  • I still plan to update some minor details of the text, namely I want to see if I can find some more recent press/blog coverage to replace the old links with. I'll take the PR out of draft once I've done that.

@Mattsi-Jansky Mattsi-Jansky marked this pull request as draft April 9, 2026 14:12
@Mattsi-Jansky Mattsi-Jansky marked this pull request as ready for review April 10, 2026 12:32
@Mattsi-Jansky Mattsi-Jansky changed the title [Draft] Update images for about page, refresh the layout Update images for about page, refresh the layout Apr 10, 2026
@russss
Copy link
Copy Markdown
Member

russss commented Apr 12, 2026

I don't like the body text styling here - it should be consistent with the rest of the website even if you think that looks worse. In general any page-specific styling is just going to make it more difficult when it comes to revising the CSS (which we're aiming to do after this year), so I'd like to keep this to an absolute minimum.

I'm inclined to lose the YouTube video at this point, although I'd welcome other opinions.

Copy link
Copy Markdown
Member

@russss russss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(Marking as "request changes" because I always forget to do this and it requires a comment)

@Mattsi-Jansky
Copy link
Copy Markdown
Contributor Author

I don't like the body text styling here - it should be consistent with the rest of the website even if you think that looks worse. In general any page-specific styling is just going to make it more difficult when it comes to revising the CSS (which we're aiming to do after this year), so I'd like to keep this to an absolute minimum.

I'm inclined to lose the YouTube video at this point, although I'd welcome other opinions.

That is a fair point, it'll be simpler to maintain the whole site if we don't make exceptions. I removed the line-height change and custom title/h1 style in eb89b70. Other than those all the text is consistent with the rest of the site, with the exception of the sub-heading.

I do think the sub-heading adds something valuable, but there isn't any similar style across the website to use in its place. I think we can either: a) push it up to _base.scss as a shared subheading style or b) remove the subheading altogether. I think it adds value but I'm happy to remove it if you prefer. What do you think?

Re: the YouTube video personally I think it adds quite a bit, though it could really do with updating as it'll be a decade old come EMF 2028. Happy to remove it as part of this PR if that's what people prefer though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants