Open
Conversation
Member
Author
|
emf_ticket(52).pkpass.zip |
Member
|
Checking in from the PR necromancy department: I am in favour of this on the whole, but I don't like the number of assets with event branding which are specific to this feature. I'd be happy to merge it if there was some more generic branding. |
russss
requested changes
Apr 12, 2026
Member
russss
left a comment
russss
left a comment
There was a problem hiding this comment.
I should remember to do "request changes" just so it's clearer what's going on in the PR view...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Generate pretty pkpass files with a user's entrance qr code.
This shells out to openssl, but only with stuff in config as arguments so I don't think this is a problem.
Passes currently expire at the
EVENT_ENDconfig option.Resolves (at least the apple side) of #1338
Looks like this currently:
