Add Content-Type: text/html; charset-utf8#39
Open
mhluska wants to merge 4 commits intoember-fastboot:masterfrom
Open
Add Content-Type: text/html; charset-utf8#39mhluska wants to merge 4 commits intoember-fastboot:masterfrom
mhluska wants to merge 4 commits intoember-fastboot:masterfrom
Conversation
|
I had a user report to me that Safari just downloads the HTML file immediately and I believe this is because my site has the |
Author
|
I've realized this is only needed in the chunkedResponse case. I've updated the PR. |
Author
|
Note: I still had to add this in fastboot-app-server to get things working in production 🤷♂️ : |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is lightly tested on my local machine. I think we need to add this because the initial FastBoot request is missing a content-type header. See my issue here: ember-fastboot/fastboot-app-server#78
This is important because some Node-based crawlers simply break without a content-type header. Also Twitterbot doesn't seem to be able to get meta tags when this header is not present.