executor: support rtos-trace without pointer CAS - #6622
Open
tianrking wants to merge 1 commit into
Open
Conversation
|
👋 Welcome, @tianrking, and thanks for opening your first pull request here! If you haven't already, please give the contributor guide a read. |
tianrking
marked this pull request as draft
July 26, 2026 17:26
tianrking
marked this pull request as ready for review
July 26, 2026 17:41
tianrking
marked this pull request as draft
July 26, 2026 18:00
tianrking
marked this pull request as ready for review
July 26, 2026 18:05
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #5698.
Summary
TaskTrackerinsertion on targets with pointer compare-and-swap support.critical_sectionon targets without pointer CAS support.riscv32imc-unknown-none-elfwithexecutor-thread,rtos-traceto the executor build matrix and pinned toolchain targets so this configuration remains covered.This keeps the fallback local to the trace task list and avoids adding a new atomic dependency for the rest of
embassy-executor.Validation
rustfmt +nightly-2025-12-11 --check --skip-children --unstable-features --edition 2024 embassy-executor/src/raw/trace.rs$env:RUSTFLAGS='-Dwarnings'; cargo check --manifest-path embassy-executor/Cargo.toml --target riscv32imc-unknown-none-elf --no-default-features --features 'platform-riscv32,executor-thread,rtos-trace'Development disclosure
OpenAI Codex assisted with the implementation and test setup. The fallback and existing CAS paths were independently cross-reviewed and compile-checked; no hardware testing was performed.